-
Notifications
You must be signed in to change notification settings - Fork 13
add JSON & TypeScript-Definitions #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PRs are always welcome |
This is already is PR for JSON support xD You can merge it after review. |
Thank you. I’m currently not in the reach of a computer. Will be back in two weeks. Then I can do a review |
update concat script
i simple copy & past the TypeScript Definition from Microsoft but only the function from the folders (include the Apache license header). Also update the Build script & the package.json. The bundle file contains only one times the license header ;) |
@fabianmoronzirfas |
@lumenn Yes I will. It's on the todo pile. Sorry for the delay. |
@fabianmoronzirfas About joining the org I'll be glad to join, as i'm currently doing a lot of Illustrator scripting, so hopefully I'll add something for everyone :) |
@lumenn invite is on its way. You should have access to the shims repos and to extendscriptr. Let me know if you need more. See https://github.com/ExtendScript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In bin/concat.js i see there is change from 2 space tab to 4 space tab, also some comments (used for debugging purposes i suppose) were removed.
Everything else seems fine for me, should we also increase version ?
Simple add JSON from https://github.com/douglascrockford/JSON-js.
I also ask about TypeScript definition file (adobe-extension-tools/extendscript-es5-shim-ts#1). We don't need 100 repository if everyone need the same :) Maybe i create own TS file the simple copy from https://github.com/DefinitelyTyped/DefinitelyTyped and make a pull request.