Skip to content

Add support for interface and record function results #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ElminsterAU
Copy link

This change allows functions returning an interface or record to work.

@lmbelo
Copy link
Member

lmbelo commented Nov 23, 2021

Can you please describe a use case or even better a unit test?

@ElminsterAU
Copy link
Author

Without these changes, while P4D does contain support for interfaces and records, it did not support them as parameters or result values for function calls.

Also, while it supported records, it did not support managed records.

Copy link
Collaborator

@checkdigits checkdigits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No response from OP.

Rejecting PR.

@checkdigits checkdigits reopened this Aug 29, 2023
@checkdigits
Copy link
Collaborator

Ok, we're going to try and merge this and get the P4D team to write some tests for it.

@checkdigits
Copy link
Collaborator

Tag @lmbelo to resolve conflicts on PR

lmbelo added a commit that referenced this pull request Sep 3, 2023
lmbelo added a commit that referenced this pull request Sep 3, 2023
@lmbelo lmbelo closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants