Askrene single path solver #8299
Open
+818
−432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add log information about the runtime of getroutes. Changelog-None: askrene: add runtime of getroutes to the logs Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Move the feature tuning algorithm to mcf.c, ie. the loops for searching a good mu and delay_feefactor to satisfy the problem constraints. We are looking to set the stage for an execution logic that allows for multiple choices of routing algorithms, mainly for experimenting without breaking the default working code. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Prefer the following programming pattern:
do_getroutes(){
do_something1();
do_something2();
do_something3();
}
rather than
get_routes(){
do_something1();
do_something2();
}
do_getroutes(){
get_routes();
do_something3();
}
Changelog-None
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Refactor MCF solver: remove structs linear_network and residual_network. Prefer passing raw data to the helper functions. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
askrene-single-path-solver
branch
from
0d0c36d to
444524a
Compare
Lagrang3
force-pushed
the
askrene-single-path-solver
branch
3 times, most recently
from
3f73b5a to
f84f5ec
Compare
The single path solver uses the same probability cost and fee cost estimation of minflow. Single path routes computed this way are suboptimal with respect to the MCF solution but still are optimal among any other single path. Computationally is way faster than MCF, therefore for some trivial payments it should be prefered. Changelog-None. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-Added: askrene: an optimal single-path solver has been added, it can be called using the developer option --dev_algorithm=single-path or by adding the layer "auto.no_mpp_support" Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-None. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
askrene-single-path-solver
branch
from
f84f5ec to
6bc2ba4
Compare
|
I benchmarked the single path solver in comparison to the MPP default solver The success rate for MPP is 82% while single path is 77%.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I want to include an internal API to askrene to compute optimally reliable
single path payments. It uses the same costs functions as the minimum cost flow solver
but with the additional constraint that only a single path solution will be considered.
In practice this is solved with the execution of Dijkstra best path algorithm therefore it is likely
to produce orders of magnitude (~x100?) faster run times.
This option can be activated by calling
getrouteswith the layerauto.no_mpp_supportor with the developer flag
--dev_algorithm=single-path.We used to compute single path routes by first doing a MCF computation and then
discarding all but one path which is computationally expensive and not even optimal.
We may use this single path computation with small payment amounts or situations for which MPP
is not supported or if time to solution is a concern.
Depends on #8163 and #7932.
TODO: