Skip to content

Use electron that exist in current path #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

yamachu
Copy link
Contributor

@yamachu yamachu commented Nov 7, 2017

bash: line 1: electron: command not found error has occurred in my env(macOSX 10.12.6, use zsh)

$ dotnet electronize start
Start Electron Desktop Application...
.NET Core 向け Microsoft (R) Build Engine バージョン 15.3.409.57025
Copyright (C) Microsoft Corporation.All rights reserved.

  sample -> /Users/yamachu/Project/CSharp/sample/bin/Debug/netcoreapp2.0/osx-x64/sample.dll
  sample -> /Users/yamachu/Project/CSharp/sample/obj/Host/bin/


Start npm install...
npm WARN ElectronNET.Host@1.0.0 No description
npm WARN ElectronNET.Host@1.0.0 No repository field.


Invoke electron - in dir: /Users/yamachu/Project/CSharp/sample/obj/Host/node_modules/.bin
bash: line 1: electron: command not found


dotnet electronize start  10.04s user 1.90s system 84% cpu 14.061 total

So I changed Execute Command that called electron to use current directory's.
This change worked well in my env.

Is there any other solution?

Thanks

@robertmuehsig
Copy link
Collaborator

Oh - stupid mistake by me - looks good!

@robertmuehsig robertmuehsig merged commit b552d0b into ElectronNET:master Nov 7, 2017
@robertmuehsig robertmuehsig added this to the 0.0.7 milestone Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants