Skip to content

HostHook.CallAsync should use TaskCompletionSource.SetException instead of throwing exception #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2020
Merged

HostHook.CallAsync should use TaskCompletionSource.SetException instead of throwing exception #430

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1238854
Merge pull request #1 from freosc/CookieHandling
freosc Jun 8, 2020
519fb53
Merge pull request #2 from ElectronNET/master
freosc Jun 8, 2020
37ae869
HostHook CallAsync
Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ElectronNET.API/HostHook.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,14 @@ public Task<T> CallAsync<T>(string socketEventName, params dynamic[] arguments)
{
BridgeConnector.Socket.Off(socketEventName + "Error" + guid);
Electron.Dialog.ShowErrorBox("Host Hook Exception", result.ToString());
taskCompletionSource.SetException(new Exception($"Host Hook Exception {result}"));
});

BridgeConnector.Socket.On(socketEventName + "Complete" + guid, (result) =>
{
BridgeConnector.Socket.Off(socketEventName + "Error" + guid);
BridgeConnector.Socket.Off(socketEventName + "Complete" + guid);
T data;
T data = default;

try
{
Expand All @@ -105,7 +106,8 @@ public Task<T> CallAsync<T>(string socketEventName, params dynamic[] arguments)
}
catch (Exception exception)
{
throw new InvalidCastException("Return value does not match with the generic type.", exception);
taskCompletionSource.SetException(exception);
//throw new InvalidCastException("Return value does not match with the generic type.", exception);
}

taskCompletionSource.SetResult(data);
Expand Down