Update to .NET Core 3.0 #313

robertmuehsig · 2019-10-03T20:32:02Z

Based on this PR #300 all packages are updated to .NET Core 3.0 + the build files should point to the correct environment.

Not sure if on the NPM part, but we will see what the CI Systems tells us :)

ElectronNET.API/ElectronNET.API.csproj

robertmuehsig · 2019-10-05T11:55:13Z

AFAIK this is the most recent package I found. Von meinem iPhone gesendet Am 05.10.2019 um 13:32 schrieb Maher Jendoubi <notifications@github.com>: @MaherJendoubi commented on this pull request.

________________________________ In ElectronNET.API/ElectronNET.API.csproj<#313 (comment)>:

<Exec Command="$(ProjectDir)devCleanup.cmd" IgnoreExitCode="true" /> </Target> <Target Name="PostBuild" AfterTargets="PostBuildEvent" Condition="'$(OS)' != 'Windows_NT'"> <Exec Command="$(ProjectDir)devCleanup.sh" IgnoreExitCode="true" /> </Target> <ItemGroup> - <PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.1.1" /> + <PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.2.0" /> <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-18618-05"> Why not upgrade this package reference? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#313?email_source=notifications&email_token=AAFYXX3B4TLUPISGYSYB6P3QNB3NJA5CNFSM4I5H4NQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG76CJY#pullrequestreview-297787687>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAFYXX6RVTAPJXKAD7IJYNDQNB3NJANCNFSM4I5H4NQA>.

MaherJendoubi

you can use this: <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-19367-01">

robertmuehsig · 2019-10-07T21:42:38Z

A couple of "issues" I want to solve before I merge this (there errors can be seen here:

During the build I get this error message (buildAll.cmd)

(c) 2018 Microsoft Corporation. All rights reserved.
C:\projects\electron-net\ElectronNET.WebApp\obj\desktop\custom\ElectronHostHook>tsc -p . --sourceMap false
connector.ts(2,33): error TS2503: Cannot find namespace 'SocketIO'.
index.ts(7,25): error TS2503: Cannot find namespace 'SocketIO'.
C:\projects\electron-net\ElectronNET.WebApp\obj\desktop\custom\ElectronHostHook>
Build Electron Desktop Application...
Executing electron magic in this directory: C:\projects\electron-net\ElectronNET.WebApp\bin\desktop
Create electron-builder configuration file...

Somehow the SocketIO namespace during the ElectronHostHook stuff is "broken" (at least from in my CI and on my machine)

The linux build seems to be broken - maybe this issue was introduced when we switched to the electron builder

C:\projects\electron-net\ElectronNET.WebApp\obj\desktop\linux>electron-builder . --config=./bin/electron-builder.json --linux --x64 -c.electronVersion=5.0.8 --publish never
  • electron-builder  version=21.2.0 os=10.0.17763
  • loaded configuration  file=C:\projects\electron-net\ElectronNET.WebApp\obj\desktop\linux\bin\electron-builder.json
  • packaging       platform=linux arch=x64 electron=5.0.8 appOutDir=C:\projects\electron-net\ElectronNET.WebApp\bin\Desktop\linux-unpacked
  • scheduling remote build  target=snap arch=x64
  • scheduling remote build  target=appImage arch=x64
  ⨯ Checksum not specified for windows:386
github.com/develar/app-builder/pkg/download.DownloadTool
	/Volumes/data/Documents/app-builder/pkg/download/tool.go:97
github.com/develar/app-builder/pkg/download.DownloadZstd
	/Volumes/data/Documents/app-builder/pkg/download/tool.go:41
github.com/develar/app-builder/pkg/download.GetZstd
	/Volumes/data/Documents/app-builder/pkg/download/tool.go:132
github.com/develar/app-builder/pkg/remoteBuild.(*RemoteBuilder).upload
	/Volumes/data/Documents/app-builder/pkg/remoteBuild/RemoteBuilder.go:174
github.com/develar/app-builder/pkg/remoteBuild.(*RemoteBuilder).build
	/Volumes/data/Documents/app-builder/pkg/remoteBuild/RemoteBuilder.go:73
github.com/develar/app-builder/pkg/remoteBuild.ConfigureBuildCommand.func1
	/Volumes/data/Documents/app-builder/pkg/remoteBuild/RemoteBuilder.go:37
github.com/alecthomas/kingpin.(*actionMixin).applyActions
	/Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/actions.go:28
github.com/alecthomas/kingpin.(*Application).applyActions
	/Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/app.go:557
github.com/alecthomas/kingpin.(*Application).execute
	/Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/app.go:390
github.com/alecthomas/kingpin.(*Application).Parse
	/Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/app.go:222
main.main
	/Volumes/data/Documents/app-builder/main.go:90
runtime.main
	/usr/local/Cellar/go/1.12.7/libexec/src/runtime/proc.go:200
runtime.goexit
	/usr/local/Cellar/go/1.12.7/libexec/src/runtime/asm_386.s:1321  
  ⨯ C:\Users\appveyor\AppData\Roaming\npm\node_modules\electron-builder\node_modules\app-builder-bin\win\ia32\app-builder.exe exited with code ERR_ELECTRON_BUILDER_CANNOT_EXECUTE  stackTrace=
                                                                                                                                                                                      Error: C:\Users\appveyor\AppData\Roaming\npm\node_modules\electron-builder\node_modules\app-builder-bin\win\ia32\app-builder.exe exited with code ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
                                                                                                                                                                                          at ChildProcess.childProcess.once.code (C:\Users\appveyor\AppData\Roaming\npm\node_modules\electron-builder\node_modules\builder-util\src\util.ts:239:14)
                                                                                                                                                                                          at Object.onceWrapper (events.js:317:30)
                                                                                                                                                                                          at emitTwo (events.js:126:13)
                                                                                                                                                                                          at ChildProcess.emit (events.js:214:7)
                                                                                                                                                                                          at maybeClose (internal/child_process.js:915:16)
                                                                                                                                                                                          at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
                                                                                                                                                                                      From previous event:
                                                                                                                                                                                          at runCallback (timers.js:810:20)
                                                                                                                                                                                          at tryOnImmediate (timers.js:768:5)
                                                                                                                                                                                          at processImmediate [as _immediateCallback] (timers.js:745:5)
                                                                                                                                                                                      From previous event:
                                                                                                                                                                                          at RemoteBuilder.build (C:\Users\appveyor\AppData\Roaming\npm\node_modules\electron-builder\node_modules\app-builder-lib\src\remoteBuilder\RemoteBuilder.ts:52:28)
                                                                                                                                                                                          at RemoteTarget.finishBuild (C:\Users\appveyor\AppData\Roaming\npm\node_modules\electron-builder\node_modules\app-builder-lib\src\linuxPackager.ts:99:30)
                                                                                                                                                                                          at <anonymous>

Besides the .NET Core 3.0 update the build commands should not install any NPM tools globally, because IMHO this feels wrong nowadays.
If anyone has a good idea how to solve the SocketIO error build and why the linux build fails - just let me know. @GregorBiswanger

In theory the Travis CI build should also be triggered by this PR - this can be fixed later.

kant2002 · 2019-10-14T15:25:14Z

ElectronNET.API/ElectronNET.API.csproj

-    <PackageIconUrl>https://raw.githubusercontent.com/ElectronNET/Electron.NET/master/assets/images/electron.net-logo-square.png</PackageIconUrl>
-    <Version>1.0.0.0</Version>
+    <PackageIcon>PackageIcon.png</PackageIcon>
+    <Version>99.0.0.0</Version>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">


Better replace lines which define DocumentationFile this one big switch with just

<GenerateDocumentationFile>true</GenerateDocumentationFile>

This will have same effect but without need to generate all permutations. But this one change can be made separately from this PR

Could you point me to a documentation? I just found some links that said that this controls the XML documentation behavior. Those lines are for the NuGet package icon or do I miss something?

I cannot say anything about documentation, since I found that long time ago when lurking around MS projects or people who closely monitor .NET Core development.

Essentially this switch produce XML files in the default location, so instead of duplication configuration and paths everywhere you just include that property in the project file. You can see in the #323 how exactly it simplifies project file.

Here the links which you can find interesting:
https://github.com/dotnet/sdk/blob/b28a8efbfb30d84019351abb3aa9a2b15e008662/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.targets#L178

https://stackoverflow.com/questions/47115877/how-to-generate-xml-documentation-for-csproj-with-multiple-targets

… into netcore30

robertmuehsig · 2019-10-14T22:15:34Z

Sooo... I put some beta bits for .NET Core 3.0 on NuGet and will merge this branch to master.

https://www.nuget.org/packages/ElectronNET.API/5.30.0-beta

dealproc · 2019-10-17T05:11:44Z

Hi there. I am curious if there is a resolution to this. I am working with your 5.30.0-beta version and am seeing the same (or similar) stacktrace as is listed above. I am, however, running this on Mint Linux instead of Windows.

I also had another issue that I tracked down to not having a specific "linux": { ... } target specified within my manifest, but that is a meh issue.

If there is anything I can do in order to provide you further information to assist in resolving this, please let me know.

EnableEndpointRouting should be set to false. Otherwise people will get error: Application startup exception: System.InvalidOperationException: Endpoint Routing does not support 'IApplicationBuilder.UseMvc(...)'. To use 'IApplicationBuilder.UseMvc' set 'MvcOptions.EnableEndpointRouting = false' inside 'ConfigureServices(...). The solution is even proposed in stack trace. Issue was opened on dotnet/aspnetcore#9542 and it is explained there what should be done.

jimbuck · 2019-10-23T04:06:18Z

Maybe I can help with the NPM dependency issue! The global install is definitely not the way to go these days. Thankfully there is a better approach built right into NPM via a command called npx:

Old:

npm install -g electron-builder
electron-builder init

New:

npx electron-builder init

The old way would install the tool globally, and there is no way to override which version was being used here.

The new way will either use the locally installed version (if present) or it will download the latest into a cache (but not global) and execute it. This means a local version (found under node_modules/.bin) takes priority, but falls back to running it directly from the latest.

npx is included in all npm installs since npm@5.2.0, so it should be just fine to require this dependency.

I actually forked this project to address this approach, so I have some of the changes already made around this. I just created a PR for the netcore30 branch that you can find here: #328.

dealproc · 2019-10-24T23:07:06Z

~~I'll give it a shot this evening and see where it takes me. Thank you for the update.~~

I gave it a shot, and still having the same issue... I may need to wait until electronize is patched before I can go further.

aboimpinto · 2019-10-27T21:56:23Z

Is this ready to be merged?

Thanks!

Converted global npm dependencies to use npx

Update to .NET Core 3.0

e25b89f

robertmuehsig mentioned this pull request Oct 3, 2019

initial update for .net core 3 preview2 #221

Closed

robertmuehsig added 2 commits October 3, 2019 23:07

fix build issues

b3bb3ce

build

5cd11a8

MaherJendoubi reviewed Oct 5, 2019

View reviewed changes

ElectronNET.API/ElectronNET.API.csproj Outdated Show resolved Hide resolved

MaherJendoubi reviewed Oct 5, 2019

View reviewed changes

robertmuehsig added 3 commits October 7, 2019 22:48

update github sourcelink and framework reference

f1eaffb

global npm outside of build commands

25f35e3

test

8dd5d15

kant2002 reviewed Oct 14, 2019

View reviewed changes

robertmuehsig mentioned this pull request Oct 14, 2019

Fix buildAll.cmd and buildAll.sh when running on clear repo #321

Merged

robertmuehsig added 5 commits October 14, 2019 22:44

fix build issues on windows

b7e7ace

beta...

54ff11a

Merge branch 'master' into netcore30

2c14693

small changes for version stuff

14d0270

Merge branch 'netcore30' of https://github.com/ElectronNET/Electron.NET…

fbc5b93

… into netcore30

documentation and one minor adjustment

f64b780

tadic-luka and others added 2 commits October 22, 2019 10:48

Converted global npm dependencies to use npx.

b6fb1cb

jimbuck mentioned this pull request Oct 23, 2019

Converted global npm dependencies to use npx #328

Merged

robertmuehsig added 2 commits October 28, 2019 23:30

Merge pull request #327 from tadic-luka/patch-1

5af8e48

Thanks!

Merge pull request #328 from jimbuck/netcore30

239d914

Converted global npm dependencies to use npx

robertmuehsig merged commit b69d4d2 into master Oct 28, 2019

robertmuehsig deleted the netcore30 branch May 1, 2020 20:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update to .NET Core 3.0 #313

Update to .NET Core 3.0 #313

Uh oh!

robertmuehsig commented Oct 3, 2019

Uh oh!

Uh oh!

robertmuehsig commented Oct 5, 2019 via email

Uh oh!

MaherJendoubi left a comment •

edited

Loading

Uh oh!

robertmuehsig commented Oct 7, 2019

Uh oh!

kant2002 Oct 14, 2019

Uh oh!

robertmuehsig Oct 14, 2019

Uh oh!

kant2002 Oct 14, 2019

Uh oh!

robertmuehsig commented Oct 14, 2019

Uh oh!

dealproc commented Oct 17, 2019

Uh oh!

jimbuck commented Oct 23, 2019

Uh oh!

dealproc commented Oct 24, 2019 •

edited

Loading

Uh oh!

aboimpinto commented Oct 27, 2019

Uh oh!

Uh oh!

Uh oh!

Update to .NET Core 3.0 #313

Update to .NET Core 3.0 #313

Uh oh!

Conversation

robertmuehsig commented Oct 3, 2019

Uh oh!

Uh oh!

robertmuehsig commented Oct 5, 2019 via email

Uh oh!

MaherJendoubi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robertmuehsig commented Oct 7, 2019

Uh oh!

kant2002 Oct 14, 2019

Choose a reason for hiding this comment

Uh oh!

robertmuehsig Oct 14, 2019

Choose a reason for hiding this comment

Uh oh!

kant2002 Oct 14, 2019

Choose a reason for hiding this comment

Uh oh!

robertmuehsig commented Oct 14, 2019

Uh oh!

dealproc commented Oct 17, 2019

Uh oh!

jimbuck commented Oct 23, 2019

Uh oh!

dealproc commented Oct 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aboimpinto commented Oct 27, 2019

Uh oh!

Uh oh!

MaherJendoubi left a comment •

edited

Loading

dealproc commented Oct 24, 2019 •

edited

Loading