Skip to content

Fix inspectdb #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 14, 2021
Merged

Fix inspectdb #96

merged 9 commits into from
Jan 14, 2021

Conversation

aceofwings
Copy link

Pull Request with Skipped Tests Removed.

Field Info was included from earlier versions of Django since collation support was added, thus breaking introspection.

@OskarPersson
Copy link
Collaborator

Please don't open new PRs when making changes. Just push the changes to your branch in your fork and the PR is updated automatically.

@aceofwings
Copy link
Author

aceofwings commented Jan 14, 2021

Apologies, I just made a mistake on my commit history and made the quick decision to remove the branch. Anyways I removed 2 skipped tests under inspectdb.

Edit
Looks like I can only remove one test for 3.1 test pass.

aceofwings and others added 3 commits January 13, 2021 21:54
@aceofwings
Copy link
Author

Pushed changes include adding Positive Integer Field. I think this resolves most of the issues.

@OskarPersson
Copy link
Collaborator

Thanks!

@OskarPersson OskarPersson merged commit 79e421a into ESSolutions:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants