Skip to content

Added Tombstone Analyzer for Tombstone report generation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 30, 2016

Conversation

frenck
Copy link
Contributor

@frenck frenck commented Dec 30, 2016

Added tombstone-analyzer.
Removed php7cc, because of an outdated dependency, which causes a conflict with the tombstone-analyzer.

@frenck frenck requested review from a user, Marascon and brammittendorff-dd December 30, 2016 09:29
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend creating an issue in the php7cc repository about this as having it is quite handy.

@frenck
Copy link
Contributor Author

frenck commented Dec 30, 2016

@Hipio There is already one, which was closed by the author.

The php7cc codebase is not compatible with the v2+ php-parser lib. I saw quotes like "Use the phar distribution" and other useless stuff. Conclusion: The author is not intending to upgrade / maintain the codebase.

php7cc is handy indeed, but there are multiple alternatives as well...

@ghost
Copy link

ghost commented Dec 30, 2016

@frenck I see, well, then we'll just use something else, it's indeed not a big deal.

@frenck frenck merged commit 979ab3e into master Dec 30, 2016
@frenck frenck deleted the feature/adds-tombstone-analyzer branch December 30, 2016 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants