Skip to content

Handle / in lambda handlers #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 26, 2020

Conversation

Czechh
Copy link
Contributor

@Czechh Czechh commented Aug 25, 2020

What does this PR do?

While using the serverless datadog plugin if a handler is inside of a folder then we get the following error:

[ERROR] Runtime.ImportModuleError: Unable to import module 'datadog_lambda.handler': No module named 'lambda/handler' |  
-- | --

To fix this we simply need to make sure we replace / for . before loading it in the layer handler.

Motivation

Started from this issue DataDog/serverless-plugin-datadog#44

Testing Guidelines

  • Integration tests work
  • Also verified with a manual test using a handler with . instead of / and it works great.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@Czechh Czechh requested a review from a team as a code owner August 25, 2020 16:51
@tianchu
Copy link
Collaborator

tianchu commented Aug 25, 2020

@Czechh mind adding some unit tests?

@Czechh
Copy link
Contributor Author

Czechh commented Aug 25, 2020

@tianchu added units for the helper. Good call

@Czechh Czechh merged commit a381b69 into master Aug 26, 2020
@Czechh Czechh deleted the sergio.prada/handle-slashes-in-lambda-handler branch August 26, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants