Skip to content

Add resource and executedversion to enhanced lambda metrics #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jcstorms1
Copy link
Contributor

@jcstorms1 jcstorms1 commented Jun 11, 2020

What does this PR do?

Adds the resource and executedversion tags to the enhanced lambda metrics
Adds new tests

Motivation

These tags are already available for lambda metrics and adding them to enhanced metrics provides consistent tagging.

Testing Guidelines

Unittest in testing script

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@jcstorms1 jcstorms1 requested a review from a team as a code owner June 11, 2020 15:20
Copy link
Contributor

@DarcyRaynerDD DarcyRaynerDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcstorms1 jcstorms1 merged commit 16eba03 into master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants