Skip to content

Add default lambda handler, for zero-code change instrumentation #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2020

Conversation

DarcyRaynerDD
Copy link
Contributor

@DarcyRaynerDD DarcyRaynerDD commented May 21, 2020

What does this PR do?

Adds a 'handler' file, that can be pointed to by the user without having to change their code. Using this file involves two steps.

Set the handler to ''datadog_lambda.handler.handler"
Set 'DD_LAMBDA_HANDLER' to the actual handler

Motivation

What inspired you to submit this pull request?

Testing Guidelines

How did you test this pull request?

Additional Notes

Anything else we should know when reviewing?

Checklist

  • Member of the Datadog team has run integration tests and updated snapshots if necessary

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner May 21, 2020 19:25
Copy link
Collaborator

@tianchu tianchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for a suggestion on the env var naming.

@DarcyRaynerDD DarcyRaynerDD merged commit d0f88d9 into master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants