Skip to content

fix: http.url tag to include protocol #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025

Conversation

duncanista
Copy link
Contributor

@duncanista duncanista commented May 23, 2025

What does this PR do?

Updates http.url tag to include protocol.

Motivation

Issue where Next Gen Extension was not able to parse it as a URL, this will be fixed there, but this should include the protocol.

Testing Guidelines

Unit test and integration tests.

Additional Notes

n/a

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@duncanista duncanista changed the title Jordan.gonzalez/inferred spans/fix http url fix: http.url tag to include protocol May 23, 2025
@duncanista duncanista marked this pull request as ready for review May 23, 2025 12:23
@duncanista duncanista requested review from a team as code owners May 23, 2025 12:23
@duncanista duncanista merged commit 64f81da into main May 23, 2025
60 checks passed
@duncanista duncanista deleted the jordan.gonzalez/inferred-spans/fix-http-url branch May 23, 2025 14:15
Copy link
Contributor

@purple4reina purple4reina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants