Patching http clients erase existing headers #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarcyRaynerDD
approved these changes
Apr 9, 2020
tianchu
force-pushed
the
tian.chu/fix-httplib-patch
branch
from
06ee151 to
3002377
Compare
tianchu
force-pushed
the
tian.chu/fix-httplib-patch
branch
from
3002377 to
1fac0fa
Compare
DarcyRaynerDD
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ebeee64 introduced a bug into the http clients patching -- existing headers may potentially be erased when injecting Datadog trace context headers, and only Datadog trace context headers will be sent with the request.
This is because some clients store headers in a dict-like objects, such as requests.structures.CaseInsensitiveDict and botocore.awsrequest.HeadersDict. These objects won't pass the
isinstance(..., dict)test.Instead of testing
isinstance(..., dict), we should testisinstance(..., MutableMapping).Checklist