Skip to content

Publish and list layers in ap-east-1 as well #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

hussfelt
Copy link
Contributor

Note: Please remember to review the contribution guidelines
if you have not yet done so.

What does this PR do?

This enables publishing and listing layers in ap-east-1 alongside all other regions

Motivation

We can not use the datadog-log-forwarder in ap-east-1.
https://github.com/DataDog/datadog-serverless-functions/tree/master/aws/logs_monitoring

Testing Guidelines

No testing has been performed.

Additional Notes

Yes, Hong Kong is using another type of token when talking to the AWS API, version 2. Thus I recommend that this is tested in your AWS environment before accepting.

https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_enable-regions.html

Checklist

  • Member of the Datadog team has run integration tests and updated snapshots if necessary

@hussfelt hussfelt requested a review from a team as a code owner March 16, 2020 09:56
@hussfelt
Copy link
Contributor Author

@sfirrin @tianchu any insights here?
If this can not be solved here we need to roll out our own layers to fix this.

Please advice :)

@tianchu
Copy link
Collaborator

tianchu commented Mar 18, 2020

@sfirrin @tianchu any insights here?
If this can not be solved here we need to roll out our own layers to fix this.

Please advice :)

Hi @hussfelt, thanks for your PR, and we are still evaluating. Meanwhile, you can install the "layer" using PyPI.

@DarcyRaynerDD
Copy link
Contributor

Thanks for this @hussfelt. I'm going to merge this PR in, and work on getting the layer published to that region.

@DarcyRaynerDD DarcyRaynerDD merged commit 1503b3c into DataDog:master Mar 25, 2020
@hussfelt
Copy link
Contributor Author

@DarcyRaynerDD would you mind circling back when that is done?
We are eager to switch over from our current solution :-)

@DarcyRaynerDD
Copy link
Contributor

We've released the layers to ap-east-1. Let us know if that resolves your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants