Add integration tests #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarcyRaynerDD
approved these changes
Mar 10, 2020
| # Return value snapshot file format is snapshots/return_values/{handler}_{runtime}_{input-event} | ||
| snapshot_path="./snapshots/return_values/${function_name}_${input_event_name}.json" | ||
|
|
||
| return_value=$(serverless invoke -f $function_name --path "./input_events/$input_event_file") |
There was a problem hiding this comment.
The invoke with return value is a neat trick
| raw_logs=$(serverless logs -f $function_name --startTime $script_start_time) | ||
|
|
||
| # Replace invocation-specific data like timestamps and IDs with XXXX to normalize logs across executions | ||
| logs=$( |
There was a problem hiding this comment.
Also pretty cool trick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These integration tests do the following:
To run integration tests for new changes to the layer:
BUILD_LAYERS=true DD_API_KEY=XXXX aws-vault exec sandbox-account-admin -- ./scripts/run_integration_testsTo regenerate snapshots:
UPDATE_SNAPSHOTS=true DD_API_KEY=XXXX aws-vault exec sandbox-account-admin -- ./scripts/run_integration_testsThis PR also makes a change to the layer itself to hook into the existing request patching so that if env var
DD_INTEGRATION_TEST=true, each HTTP request will be logged in this format:HTTP GET https://ip-ranges.datadoghq.com/ Headers: ["x-datadog-parent-id:XXXX", "x-datadog-sampling-priority:2", "x-datadog-trace-id:XXXX"] Data: {}so that we can see in the snapshot tests if any HTTP requests have changed.
This is the first step of the integration tests so we are only running them locally for now. In the future we will integrate these tests into our CI.
Testing Guidelines
I've run this many times locally and it is working as expected without being flaky.
Additional Notes
Anything else we should know when reviewing?