Skip to content

Fix wrapping for multiple handler functions in one file #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

tianchu
Copy link
Collaborator

@tianchu tianchu commented Mar 9, 2020

What does this PR do?

#46 breaks wrapping when multiple handlers for different lambda functions live in the same python file -- only the first handler will be wrapped.

Need to step back from using a class variable to setting an attribute on the wrapped handler for determining whether the datadog wrapper should be applied or not. This approach still fix the prominent case when the extra wrapper is applied by the datadog serverless plugin.

@tianchu tianchu requested a review from a team as a code owner March 9, 2020 19:01
Copy link
Contributor

@DarcyRaynerDD DarcyRaynerDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianchu tianchu merged commit a891d91 into master Mar 9, 2020
@tianchu tianchu deleted the tian.chu/fix-multi-handlers branch March 9, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants