Skip to content

chore: update build to output directly to path #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

duncanista
Copy link
Contributor

What does this PR do?

Updated Dockerfile and build_layers.sh to build and output directly into path without using docker create and docker cp.

Motivation

Be able to run this inside a GitLab job.

Testing Guidelines

  • Builds layers as expected
  • Action checks

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

updated script to output directly on build, allowing me to run this locally and in a gitlab job
@duncanista duncanista requested a review from a team as a code owner January 26, 2024 18:47
… into jordan.gonzalez/update-build-to-output
@duncanista duncanista merged commit 7400874 into main Jan 26, 2024
@duncanista duncanista deleted the jordan.gonzalez/update-build-to-output branch January 26, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants