Skip to content

fix: urllib <2.1 > 2 for python 3.10+ #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LewisCowlesMotive
Copy link

@LewisCowlesMotive LewisCowlesMotive commented Oct 13, 2023

What does this PR do?

Should provide python3.10 users with a higher version of urllib

Motivation

Installing datadog-lambda is causing urllib to downgrade in a project I am working on, and leading to flaky dependency resolution.

Testing Guidelines

I'm going to use your github actions 😄

Additional Notes

Please see #376 and #371

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@LewisCowlesMotive
Copy link
Author

Integration tests failing seems to be a flake.

link to relevant log lines

No AWS credentials were found in the environment.
Note that only Datadog employees can run these integration tests.

@LewisCowlesMotive LewisCowlesMotive marked this pull request as ready for review October 13, 2023 14:37
@LewisCowlesMotive LewisCowlesMotive requested a review from a team as a code owner October 13, 2023 14:37
@astuyve
Copy link
Contributor

astuyve commented Oct 17, 2023

Closing in favor of #380 as per #376 (comment)

@astuyve astuyve closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants