Skip to content

chore: bump dependencies #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

mbelang
Copy link

@mbelang mbelang commented Nov 4, 2019

Note: Please remember to review the contribution guidelines
if you have not yet done so.

What does this PR do?

Update to latest dependencies

Motivation

Our internal libraries wrapping ddtrace are using latest datadog library versions. Also the library in it's current form is not very flexible in term of dependencies. It should allow ranges. If you want me to put some ranges instead of >= please feel free to comment with suggestions.

Testing Guidelines

Running the tests and all green gives me enough confidence.

@mbelang mbelang requested a review from a team as a code owner November 4, 2019 19:50
@mbelang
Copy link
Author

mbelang commented Nov 4, 2019

@tianchu please.

@mbelang
Copy link
Author

mbelang commented Nov 4, 2019

Also what is the release procedure? Is it automated or I need to bump the version file manually with that PR?

@tianchu
Copy link
Collaborator

tianchu commented Nov 5, 2019

@mbelang Hi Maxime, thank you for the pull request!

For installations through AWS Layer, we do test everything before release, so it is safe to pick up the latest version for every release. However installations through pip will automatically pick up the latest version whenever a customer deploys a lambda function. Breaking changes do occasionally & accidentally get released in minor/patch updates, and sometimes it takes days for the community to get things fixed. This also help us to ensure installations of the same version from AWS Layer and from pip share the same version of dependencies.

I can help test and publish a new version to AWS once you pin down the versions :)

@mbelang
Copy link
Author

mbelang commented Nov 5, 2019

@tianchu Sorry I didn't know that particularity with Lambda Layers. We install python dependencies through serverless framework and a python plugin. We use python poetry as a dependency manager which ensures versions via lock file. I understand it does make sense in that particular context though so I reverted to pinned versions.

Thank you

@tianchu tianchu mentioned this pull request Nov 5, 2019
@tianchu
Copy link
Collaborator

tianchu commented Nov 5, 2019

Unfortunately I ran into some unexpected errors from the latest datadog library when testing in an actual lambda environment. I have to investigate this further, created a new PR here: #27, will try to bundle it into our next feature release.

Again, thank you for the PR! We will also try set up circle ci to remind us for out dated dependencies in the future.

@tianchu tianchu closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants