Catch invocation event tag extraction exceptions #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves
self.response
initialization and the logic to extract span tags from the event that invokes the Lambda function within atry...catch
so it doesn't break the Lambda.Motivation
In general, we shouldn't break the user's function from executing. In this case, if the invoking event is not what we expect, we can break the function from being executed. For example, an S3 event that doesn't have an
arn
field raised this error:Catching the exception won't break the execution of the function and will still allow us to debug an issue.
Testing Guidelines
Passed unit tests and integration tests. Also tested my own build of the layer.
Additional Notes
Types of Changes
Check all that apply