Skip to content

Update dependencies #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Conversation

DarcyRaynerDD
Copy link
Contributor

What does this PR do?

Updates dependencies of datadog-lambda-python that had fallen behind

Motivation

We were missing support for configuring trace filters correctly.

Testing Guidelines

I reran the integration tests. It added these errors to the output:

/var/runtime/botocore/vendored/requests/__init__.py:91: RequestsDependencyWarning: urllib3 (1.26.2) or chardet (3.0.4) doesn't match a supported version!
RequestsDependencyWarning)

I also re-ran the the integration tests without the dependency update, and got the same error line. It doesn't appear to happen with real lambdas, so it might be from a local dependency we include with the test.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner December 7, 2020 15:14
Copy link
Contributor

@Czechh Czechh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarcyRaynerDD DarcyRaynerDD merged commit eeffcc6 into master Dec 7, 2020
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/update-dependencies branch December 7, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants