Skip to content

hide “Deactivate now” button once deactivated #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

as6325400
Copy link
Contributor

Fixes #2687

Use getDeactivatetime() to check whether the Deactivate time field is set, and decide accordingly whether to display the Deactivate now button.

@nickygerritsen
Copy link
Member

Now the button doesn't show if a deactivate time is set, even if it is in the future. Is that what we want? I'd say we only hide it if the deactivate time is in the past?

@as6325400
Copy link
Contributor Author

Now the button doesn't show if a deactivate time is set, even if it is in the future. Is that what we want? I'd say we only hide it if the deactivate time is in the past?

Sorry, I didn’t notice that—thanks for pointing it out! I’ve updated the condition so that the button only hides if the deactivation time is in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Deactivate now" button still visible after deactivation
2 participants