Problem with statement cannot be created in the Jury web interface

[zapotocnylubos]

Description of the problem

Cannot create a problem with text/statement from the jury web interface.
Without a statement file, a problem can be normally created.

Your environment

Include details about your installation here.

• DOMjudge version = 6a99afc but also not working on 8.3.0 release
• Operating system = Ubuntu 22.04
• Webserver = docker stack, both development and production

Steps to reproduce

Replace this with a description of how we can reproduce your bug.

• download version 8.3.0 or main Github branch
• startup project (docker compose up -d) and wait for the initial setup
• login into the jury account (docker compose exec domjudge cat etc/initial_admin_password.secret to get the password)
• go to problem(s) administration (http://100.105.42.72:12345/jury/problems)
• click "Add new problem"
• fill "Name" and "Timelimit" fields
• choose any pdf for the "Problem statement" field
• submit
• see error An exception occurred while executing a query: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1' for key 'PRIMARY'

error.pdf

This happens, because the system tries to do the same insert twice into the problem_statement_content table.

INSERT INTO problem_statement_content (content, probid) VALUES (?, ?)

This problem occurs on latest main branch, both locally and on public demo as well as on 8.3.0 release tag!!

Expected behaviour

Problem should be created

Actual behaviour

Problem is not created, exception happens

Any other information that you want to share?

For now, I tracked the problem and validated in on 8.3.0 and main branch
The problem seems to be related to double calling to the

domjudge/webapp/src/Entity/Problem.php

Line 457 in 6a99afc

public function processProblemStatement(): void

[zapotocnylubos]

The problem is, that there is a #[ORM\PrePersist] annotation for

domjudge/webapp/src/Entity/Problem.php

Line 457 in 6a99afc

public function processProblemStatement(): void

and the pre-persist gets called twice,

first normally by UnitOfWork from Doctrine, which manages the $visited, so it does not call the pre-persist method twice, even when you call $em->persist(...) multiple times.

https://github.com/doctrine/orm/blob/1fe1a6a048dd420d06704f72b296a463237d7603/src/UnitOfWork.php#L1778-L1782

But then there is this

domjudge/webapp/src/Controller/BaseController.php

Lines 119 to 125 in 6a99afc

	// Call the prePersist lifecycle callbacks.
	// This used to work in preUpdate, but Doctrine has deprecated that feature.
	// See https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/events.html#events-overview.
	$metadata = $this->em->getClassMetadata($entity::class);
	foreach ($metadata->lifecycleCallbacks['prePersist'] ?? [] as $prePersistMethod) {
	$entity->$prePersistMethod();
	}

which completely bypasses that $visited check and calls the pre-persist method anyway, in this case for the second time, resulting in this error.

Is this code necessary, or is there any reason to use both this "hack" and the #[ORM\PrePersist]?

[cubercsl]

It seems that you cannot upload the statement when creating a new problem, but you can upload the statement for an existing problem (as a temporary workaround).