Added namespace limiters to all client.List() calls in pgbackrest and… #3438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
reviewed
Oct 27, 2022
dsessler7
force-pushed
the
namespace-limiters
branch
2 times, most recently
from
fe24161 to
d5dd893
Compare
benjaminjb
approved these changes
Oct 28, 2022
… volumes files in the controller. Changed List calls to consistently use ListOptions struct or individual ListOption arguments, but not a mixture of both. Issue: [sc-13871] Issue: [sc-16139] Issue: CrunchyData#3058 Issue: CrunchyData#3364
dsessler7
force-pushed
the
namespace-limiters
branch
from
d5dd893 to
5679152
Compare
|
When might we expect this fix to be released? I think I may have run into a related problem. BTW, am I wrong in thinking that I can use a pgbackrest backup from a non-PGO instance as a dataSource for a new PGO cluster? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… volumes files in the controller. This change was mandated by [sc-16139] and we believe the changes, particularly in
volumes.go, should also solve the problem seen by the customer in [sc-13871].Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
A couple customers have seen issues when doing restores and volume moves with multiple clusters having the same name but being in different namespaces.
What is the new behavior (if this is a feature change)?
Other Information:
Issue: [sc-16139]
Issue: [sc-13871]
Issue: #3364
Issue: #3058