Fix browser test in Node10 environment #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The window mock was broken because it miss `Symbol`, `Date` and other global definitions. Set the window as `globalThis` and then define the navigator in it solves the issue. A proper way of solving the issue will be use `jsdom`, however this plugin doesn't work in Node10. Also fixed an issue with timers getting hanging in some situations. The issue was catched by browser test with `--detectOpenHandles`.
ConorNeo
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The window mock was broken because it miss
Symbol,Dateand other global definitions. Set the window asglobalThisand then define the navigator in it solves the issue.A proper way of solving the issue will be use
jsdom, however this plugin doesn't work in Node10.Also fixed an issue with timers getting hanging in some situations. The issue was catched by browser test with
--detectOpenHandles.