Fix browser tests in the lite driver #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic browser tests in the lite driver is done by using a WebSocket implementation in a mocked browser. So, mocking the `window` is needed.
`boltAgent` is not configurable, so it should not be exposed in the `Config`. The `InternalConfig` interface was created for keeping the type-safety. The declaration tests were failing because of multiple `AbortSignal` definitons. This was happening because each project is using different versions of `@types/node` in the `package-lock.json`. The problem was not happening before because any interface exposed by the `neo4j-driver-core` was depending in Node defintions. The solution can be done or by remove the Node api reference or by pin the `@types/node` versions accross all packages. The first solution was choosed since the use of `string` instead `NodeJS.Platform` in the `SystemInfo` doesn't impact the usability of the `node.boltAgent.fromVersion` function.
ConorNeo
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic browser tests in the lite driver is done by using a WebSocket implementation in a mocked browser. So, mocking the
windowis needed.