Skip to content

Deprecate event triggered assertions #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xEdelweiss
Copy link
Contributor

Tests for the deprecations PR.

@TavoNiievez TavoNiievez changed the base branch from main to 5.4_codecept5 February 18, 2023 16:43
@TavoNiievez TavoNiievez force-pushed the deprecate_event_triggered branch from 2d06d30 to e878d9b Compare February 18, 2023 16:51
@TavoNiievez
Copy link
Member

@xEdelweiss Since the main branch of module-symfony is meant to work with Codeception 5 I have changed the target branch of your PR and took the liberty of doing a rebase on it, the tests are green so I will gladly merge these changes.

@TavoNiievez TavoNiievez merged commit eb4ea52 into Codeception:5.4_codecept5 Feb 18, 2023
@xEdelweiss
Copy link
Contributor Author

@TavoNiievez thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants