Make switch to frame possible

[Sieg]

As locator near the name was changed to iframe recently, and we have used that switchToIframe for switching between our frames as well, i would like to ask introducing the switchToFrame method as well alongside the old switchToIframe one, if possible.

p.s. i was not able to run the tests on this repository, would be super great to have more information how to do it in the readme.

Thanks for your work guys!

[Naktibalda]

I think that it would be better to make switchToIFrame behave as before by changing locator to match frames and iframes:

$els = $this->_findElements("iframe[name='$locator']  | frame[name='$locator']");

[Sieg]

I would not say so, as the name of method is missleading, it have IFrame in it, so it should work with iframes, even if it was possible to be used with frames before. Or, the name should be changed to switchToFrame then, and used for iframes as well. But thats just my opinion, would be better to vote for it probably :)

[Naktibalda]

Changing the name is backwards compatibility break,
making switchToIframe work with frames as before is backwards compatibility fix.

[Sieg]

Yes, but:

• Making it working as before will make the method misused again. The fix should be introduced, but with the deprecation of this functionality maybe?
• Renaming could be done with the deprecation of the old method as well, it's not critical to just rename it.

Sure, it is your decision how to handle this question, but me personally would prefer the chaos to be more organized with the time, but not just fixed to be working somehow :)

[Naktibalda]

@DavertMik thinks that switchToIframe working with frames is a feature, not a bug.

[Sieg]

@Naktibalda But it leads to misunderstandings while it does more than its described, and then people can change the code without even thinking about those "features" and one day those are stopping to work. So either you need two methods or better documentation/implementation on the old one. Feel free to do as you think is better.

[Sieg]

@Naktibalda Feel free to reopen if someone is interested in fixing this, I have just introduced clearly named methods for our project for now.

[Naktibalda]

I apologize for forgetting your pull request.

Nobody else seem to care about it and nobody has reported that original behaviour is broken, so keeping backwards compatibility is not that important.

I will merge your change.

[Naktibalda]

Released as 1.1.0