Respect base element with fillField() #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mbrodala , Could you please add a test for this change? It can be something similar to the code example that you related in the issue. |
|
@TavoNiievez I'd gladly do so if there are instructions how to set up and run the tests. |
mbrodala
force-pushed
the
patch-1
branch
3 times, most recently
from
3922cf0 to
512418a
Compare
TavoNiievez
approved these changes
Dec 8, 2021
|
@TavoNiievez Thanks for the approval, I just re-pushed an attempt to actually also test |
|
Reverted as mentioned now to unblock this first. |
|
@mbrodala so this is ready now? |
mbrodala
changed the title
|
Yes, it's ready for the issue I mentioned. Technically the other two actions are also fixed but currently I fail to test this properly. |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79