Skip to content

Update WebDriver.php #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Update WebDriver.php #31

merged 1 commit into from
Nov 16, 2020

Conversation

ThomasLandauer
Copy link
Member

Reorganizing the docs about setup. First step of what I suggested at #30 (comment)

Once you've merged all my 3 PR's from today, please rebuild the page https://codeception.com/docs/modules/WebDriver, so I can see what this looks like so far.

Questions:

  • "Note that Selenium 3.8 renamed this capability from chromeOptions to goog:chromeOptions" This obviously only applies when using Selenium - i.e. when using ChromeDriver directly, it's still chromeOptions?
  • Depending on what you answer at Docs: Drop Selenium and PhantomJS? #28 (comment), I would suggest: Tell people to start without Selenium, and see how far they'll get. Reason: Selenium installation is cumbersome, and might not be necessary. So I'd like to "sell" Selenium as (a) tool for troubleshooting if they run into problems, and (b) power tool giving additional options (which?).

Next step (depending on how much time I have :-)
I'd like to shorten https://codeception.com/docs/03-AcceptanceTests#WebDriver:

  • Remove everything that's already present here (e.g. installation instructions)
  • The "Acceptance Tests" page should be an overview page for new users, showcasing Codeception's cool features. Configuration details (like e.g. the lengthy SmartWait examples) don't belong there, and should be moved to the WebDriver module page.

Reorganizing the docs about setup. First step of what I suggested at #30 (comment)
@Naktibalda Naktibalda merged commit 1022e94 into Codeception:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants