Skip to content

Add cookie validation to auth methods #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Add cookie validation to auth methods #81

merged 2 commits into from
Dec 14, 2020

Conversation

TavoNiievez
Copy link
Member

For remembered authentication methods seeRememberedAuthentication and dontSeeRememberedAuthentication, there are some cases in which it is necessary to verify not only the role but also the generated Cookie, that is why this logic is added to these methods.

Also, to add more clarity about the internals of these methods, the class constants of the Symfony Security component are used to make these assertions.

@TavoNiievez TavoNiievez added this to the 1.5.1 milestone Dec 13, 2020
@TavoNiievez TavoNiievez merged commit 142b392 into Codeception:master Dec 14, 2020
@TavoNiievez TavoNiievez deleted the fix/auth_methods branch December 14, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant