Skip to content

Update code standards to PHP 7.1+ #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Update code standards to PHP 7.1+ #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
{
"name":"codeception/module-symfony",
"description":"Codeception module for Symfony framework",
"keywords":["codeception", "symfony"],
"homepage":"https://codeception.com/",
"type":"library",
"license":"MIT",
"authors":[
"name": "codeception/module-symfony",
"description": "Codeception module for Symfony framework",
"keywords": ["codeception", "symfony"],
"homepage": "https://codeception.com/",
"type": "library",
"license": "MIT",
"authors": [
{
"name":"Michael Bodnarchuk"
"name": "Michael Bodnarchuk"
},
{
"name": "Gustavo Nieves",
"homepage": "https://medium.com/@ganieves"
}
],
"minimum-stability": "RC",
Expand All @@ -25,7 +29,7 @@
"codeception/module-sequence": "^1.0",
"vlucas/phpdotenv": "^3.6 | ^4.1 | ^5.2"
},
"autoload":{
"autoload": {
"classmap": ["src/"]
},
"config": {
Expand Down
5 changes: 4 additions & 1 deletion src/Codeception/Lib/Connector/Symfony.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\HttpKernelBrowser;
use Symfony\Component\HttpKernel\Kernel;
use function array_keys;
use function class_alias;
use function codecept_debug;

if (Kernel::VERSION_ID < 40300) {
class_alias('Symfony\Component\HttpKernel\Client', 'Symfony\Component\HttpKernel\HttpKernelBrowser');
Expand Down Expand Up @@ -77,7 +80,7 @@ protected function doRequest($request): Response
* are updated from service container before kernel shutdown
* and injected into newly initialized container after kernel boot.
*/
public function rebootKernel()
public function rebootKernel(): void
{
if ($this->container) {
foreach (array_keys($this->persistentServices) as $serviceName) {
Expand Down
Loading