-
Notifications
You must be signed in to change notification settings - Fork 25
Added seeFormErrorMessages function #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added seeFormErrorMessages function #67
Conversation
Thanks @TavoNiievez for PR My biggest concern here that this method validates full error messages, which is useless in most of cases. Those error messages are either standard (so no reason to test the full message) or are subject to change in time. Consider the case - we try to improve error messages, and we change them on each iteration adding more and more descriptinve erros and more and more polite languages, while keeping validation rules the same. Should we update test on each wording change? I prefer not. So personally I would assert for the error field to include some text. However, not sure how to do this correctly with consistent API |
@DavertMik if i understand you correctly, what you are asking is that an Edit: That is the current behavior of |
@Naktibalda @DavertMik I've made all the requested changes based on your feedback, thanks to both of you. |
It is also present in the Laravel module.
A validation was added to allow omitting
=> null
in the array if you don't want to specify the error message.