Skip to content

Updated Test Project #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Updated Test Project #63

merged 1 commit into from
Dec 6, 2020

Conversation

TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented Nov 27, 2020

Closes #54

@TavoNiievez TavoNiievez marked this pull request as ready for review November 29, 2020 16:55
Copy link
Member

@eXorus eXorus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only did the migration from Travis to Github Actions.
I don't use SF or this module.

But it looks you did a great job. Thanks.
I added few comments, feel free to change or not.


- name: Install Symfony Sample on PHP7
if: matrix.php < 8
run: composer update --no-dev --prefer-dist --no-interaction
working-directory: framework-tests
run: composer update --no-progress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove --no-dev, --prefer-dist and --no-interaction ?

Copy link
Member Author

@TavoNiievez TavoNiievez Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no-dev: I want the latest versions of Codeception and its modules (which is included in the require-dev section in the composer.json files) to be used when running CI jobs.

  • --no-interaction: There will be no interaction anyway, the .lock files keep track of the installed recipes, it is very unlikely that any bundle will add a new recipe within a minor version and this also damages the continuous integration flow.

  • --prefer-dist: Well, this is already included in the composer.json files. In any case what the composer documentation says is 'This can speed up installs substantially on build servers and other use cases where you typically do not run updates of the vendors .' and i am intentionally running a composer update to update all dependencies to their latest version.

Here I also took into account how it is done in symfony/demo, but when analyzing each individual case, i came to the conclusion that the only thing I don't want is to see the progress of locking/downloading/installation in the logs.

@TavoNiievez TavoNiievez merged commit 7081122 into Codeception:master Dec 6, 2020
@TavoNiievez TavoNiievez deleted the tests branch December 6, 2020 17:47
@TavoNiievez TavoNiievez mentioned this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tests
2 participants