Skip to content

Support PHP 8 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Support PHP 8 #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf22c7
Support PHP8
Naktibalda Nov 26, 2020
2ab3b60
CI: ignore platform requirements on PHP8
Naktibalda Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ jobs:

strategy:
matrix:
php: [7.0, 7.1, 7.2, 7.3, 7.4]
php: [7.0, 7.1, 7.2, 7.3, 7.4, 8.0]
symfony: [3.4, 4, 5]
exclude:
- php: 7.3
symfony: 3.4
- php: 7.4
symfony: 3.4
- php: 8.0
symfony: 3.4
- php: 7.0
symfony: 4
- php: 7.0
Expand Down Expand Up @@ -70,9 +72,14 @@ jobs:
path: framework-tests
ref: symfony5

- name: Install Symfony Sample
run: |
composer update --no-dev --prefer-dist --no-interaction
- name: Install Symfony Sample on PHP7
if: matrix.php < 8
run: composer update --no-dev --prefer-dist --no-interaction
working-directory: framework-tests

- name: Install Symfony Sample on PHP8
if: matrix.php == 8.0
run: composer update --no-dev --prefer-dist --no-interaction --ignore-platform-req=php
working-directory: framework-tests

- name: Validate composer.json and composer.lock
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
],
"minimum-stability": "RC",
"require": {
"php": ">=7.0.8 <8.0",
"php": ">=7.0.8 <9.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatibility with php 8.0 does not guarantee compatibility with 8.1+ .
I personally would have blocked it at <8.1. But I've seen that that was the way to add PHP8 support elsewhere in Codeception.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not doing this every year 😄
There were no compatibility issues with 8.0 in module code across all modules, so I have high expectations for 8.1 too.

"codeception/lib-innerbrowser": "^1.3",
"codeception/codeception": "^4.0",
"ext-json": "*"
Expand Down