Skip to content

Fix strategy to match actions #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

Fix strategy to match actions #59

merged 1 commit into from
Nov 25, 2020

Conversation

TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented Nov 25, 2020 •
edited
Loading

In Linux, the basename function may have a different behavior from windows and other systems.
The conditional now verifies that the $controller string ends in the expected $action string, which has the same effect.

test-based fix.

@TavoNiievez TavoNiievez added this to the 1.4.1 milestone Nov 25, 2020
@TavoNiievez TavoNiievez merged commit 28998fd into Codeception:master Nov 25, 2020
@TavoNiievez TavoNiievez deleted the fix-route-match branch November 25, 2020 18:41
@TavoNiievez TavoNiievez mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.
1 participant
@TavoNiievez