Test the module in symfony 3.4 and php7.3+ #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That error happens because that branch of symfony-demo uses version of Doctrine incompatible with PHP 7.3+ |
Naktibalda
reviewed
Nov 26, 2020
.travis.yml
Outdated
| @@ -16,10 +16,6 @@ env: | |||
| - VERSION=5 TEST_REPO='-b symfony5 https://github.com/Codeception/symfony-demo.git' SUITES=functional,unit | |||
| matrix: | |||
| exclude: | |||
| - php: 7.3 | |||
| env: VERSION=3.4 TEST_REPO='--recurse-submodules https://github.com/Naktibalda/codeception-symfony-tests' | |||
| - php: 7.4 | |||
There was a problem hiding this comment.
@eXorus deleted .travis.yml in other modules during migration to Github Actions.
I think that this file survived by accident and can be deleted.
There was a problem hiding this comment.
I removed Travis.
I am also closing this PR due to work started on #54, thanks for your feedback.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is currently not being tested in Symfony 3.4 on PHP 7.3 and PHP 7.4 (and soon neither on php8) due to a error (you can check it in the CI Build).
Apparently this error originates from the test project code.