Removed superfluous service validation logic #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: The validation that the service exists was already done when obtaining the service. The code that is removed in this PR was not necessary.
Click to see full description.
$this->grabService() validates that the service exists and otherwise fails the test showing a very descriptive message.
module-symfony/src/Codeception/Module/Symfony.php
Lines 597 to 606 in b65b2c7
I had ignored that this implicit validation already existed when writing the functions that i edit in this PR:
logout, seeInSession, amOnAction, seeAuthentication, seeUserHasRole, dontSeeAuthentication, grabParameter, seeCurrentActionIs, seeUserPasswordDoesNotNeedRehash, amLoggedInAs.