Skip to content

Removed extra return statements #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/Codeception/Module/Symfony.php
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,6 @@ public function logout()

if (!$container->has('session')) {
$this->fail("Symfony container doesn't have 'session' service");
return;
}
$session = $this->grabService('session');

Expand Down Expand Up @@ -871,7 +870,6 @@ public function seeInSession($attrib, $value = null)

if (!$container->has('session')) {
$this->fail("Symfony container doesn't have 'session' service");
return;
}

$session = $this->grabService('session');
Expand Down Expand Up @@ -904,7 +902,6 @@ public function amOnAction($action, $params = [])

if (!$container->has('router')) {
$this->fail("Symfony container doesn't have 'router' service");
return;
}

$router = $this->grabService('router');
Expand Down Expand Up @@ -944,7 +941,6 @@ public function seeAuthentication($remembered = false)

if (!$container->has('security.helper')) {
$this->fail("Symfony container doesn't have 'security.helper' service");
return;
}

$security = $this->grabService('security.helper');
Expand All @@ -953,7 +949,6 @@ public function seeAuthentication($remembered = false)

if (!$user) {
$this->fail('There is no user in session');
return;
}

if ($remembered) {
Expand Down Expand Up @@ -981,7 +976,6 @@ public function seeUserHasRole($role)

if (!$container->has('security.helper')) {
$this->fail("Symfony container doesn't have 'security.helper' service");
return;
}

$security = $this->grabService('security.helper');
Expand All @@ -990,7 +984,6 @@ public function seeUserHasRole($role)

if (!$user) {
$this->fail('There is no user in session');
return;
}

$this->assertTrue(
Expand Down Expand Up @@ -1020,7 +1013,6 @@ public function dontSeeAuthentication($remembered = true)

if (!$container->has('security.helper')) {
$this->fail("Symfony container doesn't have 'security.helper' service");
return;
}

$security = $this->grabService('security.helper');
Expand Down Expand Up @@ -1054,7 +1046,6 @@ public function seeCurrentActionIs($action)

if (!$container->has('router')) {
$this->fail("Symfony container doesn't have 'router' service");
return;
}

$router = $this->grabService('router');
Expand All @@ -1079,7 +1070,6 @@ public function amLoggedInAs(UserInterface $user, $firewallName = 'main', $firew
$container = $this->_getContainer();
if (!$container->has('session')) {
$this->fail("Symfony container doesn't have 'session' service");
return;
}

$session = $this->grabService('session');
Expand Down