Skip to content

fix getProfile logic #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2020
Merged

fix getProfile logic #36

merged 1 commit into from
Nov 13, 2020

Conversation

TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented Nov 10, 2020

Calling:

$this->client->getResponse();

results in:

[BadMethodCallException] The "request()" method must be called before "AbstractBrowser::getRe
sponse()".

so this is never reached:

if (null === $response) {
    $this->fail("You must perform a request before using this method.");
}
return $profiler->loadProfileFromResponse($response);

@DavertMik DavertMik merged commit 595f4e5 into Codeception:master Nov 13, 2020
@TavoNiievez TavoNiievez added this to the 1.3.0 milestone Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants