Skip to content

Update dependencies #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Update dependencies #149

merged 2 commits into from
Dec 8, 2021

Conversation

ThomasLandauer
Copy link
Member

I'm just guessing this - so if it's wrong, just close it :-)

Same situation is in module-phpbrowser: https://github.com/Codeception/module-phpbrowser/blob/master/composer.json

I'm just guessing this - so if it's wrong, just close it :-)
@TavoNiievez
Copy link
Member

Hi @ThomasLandauer , eventually there should be a release of module-symfony (and any other modules) using the versions released today.
However, you will most likely not use both (1.x and 2.x) at the same time.

Because one module depends on another, and so on, updating all of them at once proved a bit difficult. But without a doubt this is something that will be done in the next version.

I haven't yet verified module-symfony compatibility with Symfony 5.4 and 6.0 and I even have new features pending, so thanks for pointing out that here is something else to add to the to-do list!

Btw, you can also try to fix the build yourself and we can merge this before, if you want. I suggest you first update the dependency locally, PHPStorm should help you by marking incompatibilities in red.

@TavoNiievez TavoNiievez added this to the 2.2.0 milestone Dec 7, 2021
@TavoNiievez
Copy link
Member

I wanted to avoid mixing updating PHP version with updating dependencies so as not to do a super difficult update, but you are right, it is something that should be done.

@ThomasLandauer
Copy link
Member Author

Never mind, it's OK for me, just thought you were maybe missing something...
All good! :-)

@TavoNiievez
Copy link
Member

thank you very much :-) I will try to do it as soon as possible

@TavoNiievez TavoNiievez changed the title Bumping lib-innerbrowser dependency to "^1.4|^2.0" Update dependencies Dec 8, 2021
@TavoNiievez TavoNiievez merged commit 6cbbd24 into Codeception:main Dec 8, 2021
@TavoNiievez
Copy link
Member

@ThomasLandauer thanks you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants