Skip to content

Changing Symfony.php -> trait #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Changing Symfony.php -> trait #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ First of all: Contributions are very welcome!
## No, my change does not require a test
So you're going to make a small change or improve the documentation? Hey, you rock!

- Just edit [`Symfony.php`](https://github.com/Codeception/module-symfony/blob/master/src/Codeception/Module/Symfony.php) on GitHub's website.
- Just edit [the respective `trait`](https://github.com/Codeception/module-symfony/tree/main/src/Codeception/Module/Symfony) on GitHub's website.
- Make sure to add a descriptive title and add an explanation for your changes.

> :bulb: You can also create a *fork* and *clone it* on your local machine, as explained in the next section.
Expand Down Expand Up @@ -39,7 +39,7 @@ It is a minimal (but complete) Symfony project, ready to run tests.
php bin/console doctrine:fixtures:load --quiet
```
<br/>
- Edit the module's source code in the `vendor/codeception/module-symfony/src/Codeception/Module/Symfony.php` file.
- Edit the trait's source code in the `vendor/codeception/module-symfony/src/Codeception/Module/Symfony/` folder.
<br/>
- If you create a new method, you can test it by adding a test in the `tests/Functional/SymfonyModuleCest.php` file.
> :bulb: Be sure to rebuild Codeception's "Actor" classes (see [Console Commands](https://codeception.com/docs/reference/Commands#Build)):
Expand All @@ -65,7 +65,7 @@ It is a minimal (but complete) Symfony project, ready to run tests.
```
> :bulb: If you've created a fork before, make sure to [sync the changes](https://stackoverflow.com/a/7244456).

- Copy the changes from the `Symfony.php` of the test project to the `src/Codeception/Module/Symfony.php` file on your Module's fork.
- Copy the changes from the trait file of the test project to the `src/Codeception/Module/Symfony/` folder of your Module's fork.
<br/>
- Commit:
```shell
Expand Down