Refactor email assertions #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
mailer:
config parameter is removed since it is no longer needed.The fewest possible changes were made to the API to make it easier for users to upgrade to version 2.
The most significant change, however, is that
seeEmailIsSent
now defaults to1
instead ofnull
. This change is made because previously an assert of typeassertGreatherThan
was made, whereas now, theEmailCount Constraint
requires that the expected number of emails be specified.Checking the exact amount of emails sent is probably what you want to assert in your tests.