Skip to content

Fix compatibility with symfony/dom-crawler < 5.3.0-BETA-1 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

nrocy
Copy link
Contributor

@nrocy nrocy commented Jan 26, 2022

Fixes #49

Wasn't sure how best to add a unit test for this, happy to update if there's a good way to do so.

@TavoNiievez FYI

Copy link
Member

@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the docblock you added is pretty well explained.

@TavoNiievez TavoNiievez added this to the 2.0.2 milestone Jan 26, 2022
@TavoNiievez TavoNiievez merged commit 108679c into Codeception:master Jan 27, 2022
@KyleWardle
Copy link

@TavoNiievez Any idea of a release date for 2.0.2? This is blocking us from upgrading our dependencies.
Cheers

@TavoNiievez
Copy link
Member

@KyleWardle Right now ;-)
Sorry for being late

@KyleWardle
Copy link

@KyleWardle Right now ;-) Sorry for being late

No worries at all, appreciate the quick response, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in PR #48 break backward compat?
4 participants