-
Notifications
You must be signed in to change notification settings - Fork 19
Code standards updated to PHP 7.3 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1c4706d
Code standards updated to PHP 7.1
TavoNiievez 7439c23
Added more typehints
TavoNiievez 186e85e
Support for Codeception 5
TavoNiievez 3a379ba
Added more typehints
TavoNiievez 101f67d
AssertSame instead of AssertEquals
TavoNiievez dd42369
temporarily use dev branch
TavoNiievez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,45 @@ | ||
{ | ||
"name":"codeception/lib-innerbrowser", | ||
"description":"Parent library for all Codeception framework modules and PhpBrowser", | ||
"keywords":["codeception"], | ||
"homepage":"https://codeception.com/", | ||
"type":"library", | ||
"license":"MIT", | ||
"authors":[ | ||
{ | ||
"name":"Michael Bodnarchuk", | ||
"email":"davert@mail.ua", | ||
"homepage":"http://codegyre.com" | ||
}, | ||
{ | ||
"name":"Gintautas Miselis" | ||
} | ||
], | ||
"minimum-stability": "RC", | ||
|
||
"require": { | ||
"php": ">=5.6.0 <9.0", | ||
"codeception/codeception": "*@dev", | ||
"symfony/browser-kit": ">=2.7 <6.0", | ||
"symfony/dom-crawler": ">=2.7 <6.0", | ||
"ext-mbstring": "*", | ||
"ext-dom": "*", | ||
"ext-json": "*" | ||
}, | ||
"require-dev": { | ||
"codeception/util-universalframework": "dev-master" | ||
}, | ||
"conflict": { | ||
"codeception/codeception": "<4.0" | ||
}, | ||
"autoload":{ | ||
"classmap": ["src/"] | ||
}, | ||
"config": { | ||
"classmap-authoritative": true | ||
}, | ||
"scripts": { | ||
"test": "codecept run --coverage-xml" | ||
} | ||
"name": "codeception/lib-innerbrowser", | ||
"description": "Parent library for all Codeception framework modules and PhpBrowser", | ||
"keywords": [ "codeception" ], | ||
"homepage": "https://codeception.com/", | ||
"type": "library", | ||
"license": "MIT", | ||
"authors": [ | ||
{ | ||
"name": "Michael Bodnarchuk", | ||
"email": "davert@mail.ua", | ||
"homepage": "https://codegyre.com" | ||
}, | ||
{ | ||
"name": "Gintautas Miselis" | ||
} | ||
], | ||
"minimum-stability": "RC", | ||
"require": { | ||
"php": "^7.3 || ^8.0", | ||
"ext-dom": "*", | ||
"ext-json": "*", | ||
"ext-mbstring": "*", | ||
"codeception/codeception": "dev-5.0-interfaces", | ||
"symfony/browser-kit": ">=4.4 <6.0", | ||
"symfony/dom-crawler": ">=4.4 <6.0" | ||
}, | ||
"require-dev": { | ||
"codeception/util-universalframework": "dev-master" | ||
}, | ||
"conflict": { | ||
"codeception/codeception": "<5.0" | ||
}, | ||
"autoload": { | ||
"classmap": [ | ||
"src/" | ||
] | ||
}, | ||
"config": { | ||
"classmap-authoritative": true | ||
}, | ||
"scripts": { | ||
"test": "codecept run --coverage-xml" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Codeception\Exception; | ||
|
||
class ExternalUrlException extends \Exception | ||
use Exception; | ||
|
||
class ExternalUrlException extends Exception | ||
{ | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary change to demonstrate the proper functioning of the CI