Skip to content

Code standards updated to PHP 7.3 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

strategy:
matrix:
php: [5.6, 7.0, 7.1, 7.2, 7.3, 7.4, 8.0]
php: [7.3, 7.4, 8.0]

steps:
- name: Checkout code
Expand Down
85 changes: 43 additions & 42 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,44 +1,45 @@
{
"name":"codeception/lib-innerbrowser",
"description":"Parent library for all Codeception framework modules and PhpBrowser",
"keywords":["codeception"],
"homepage":"https://codeception.com/",
"type":"library",
"license":"MIT",
"authors":[
{
"name":"Michael Bodnarchuk",
"email":"davert@mail.ua",
"homepage":"http://codegyre.com"
},
{
"name":"Gintautas Miselis"
}
],
"minimum-stability": "RC",

"require": {
"php": ">=5.6.0 <9.0",
"codeception/codeception": "*@dev",
"symfony/browser-kit": ">=2.7 <6.0",
"symfony/dom-crawler": ">=2.7 <6.0",
"ext-mbstring": "*",
"ext-dom": "*",
"ext-json": "*"
},
"require-dev": {
"codeception/util-universalframework": "dev-master"
},
"conflict": {
"codeception/codeception": "<4.0"
},
"autoload":{
"classmap": ["src/"]
},
"config": {
"classmap-authoritative": true
},
"scripts": {
"test": "codecept run --coverage-xml"
}
"name": "codeception/lib-innerbrowser",
"description": "Parent library for all Codeception framework modules and PhpBrowser",
"keywords": [ "codeception" ],
"homepage": "https://codeception.com/",
"type": "library",
"license": "MIT",
"authors": [
{
"name": "Michael Bodnarchuk",
"email": "davert@mail.ua",
"homepage": "https://codegyre.com"
},
{
"name": "Gintautas Miselis"
}
],
"minimum-stability": "RC",
"require": {
"php": "^7.3 || ^8.0",
"ext-dom": "*",
"ext-json": "*",
"ext-mbstring": "*",
"codeception/codeception": "dev-5.0-interfaces",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary change to demonstrate the proper functioning of the CI

"symfony/browser-kit": ">=4.4 <6.0",
"symfony/dom-crawler": ">=4.4 <6.0"
},
"require-dev": {
"codeception/util-universalframework": "dev-master"
},
"conflict": {
"codeception/codeception": "<5.0"
},
"autoload": {
"classmap": [
"src/"
]
},
"config": {
"classmap-authoritative": true
},
"scripts": {
"test": "codecept run --coverage-xml"
}
}
4 changes: 4 additions & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ Parent library for all Codeception framework modules and PhpBrowser.
[![Total Downloads](https://poser.pugx.org/codeception/lib-innerbrowser/downloads)](https://packagist.org/packages/codeception/lib-innerbrowser)
[![License](https://poser.pugx.org/codeception/lib-innerbrowser/license)](/LICENSE)

## Requirements

* `PHP 7.3` or higher.

## Installation

```
Expand Down
6 changes: 5 additions & 1 deletion src/Codeception/Exception/ExternalUrlException.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
<?php

declare(strict_types=1);

namespace Codeception\Exception;

class ExternalUrlException extends \Exception
use Exception;

class ExternalUrlException extends Exception
{
}
7 changes: 3 additions & 4 deletions src/Codeception/Lib/Framework.php
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
<?php

declare(strict_types=1);

namespace Codeception\Lib;

/**
* Abstract module for PHP frameworks connected via Symfony BrowserKit components
* Each framework is connected with it's own connector defined in \Codeception\Lib\Connector
* Each module for framework should extend this class.
*
*/
abstract class Framework extends InnerBrowser
{
/**
* Returns a list of recognized domain names
*
* @return array
*/
protected function getInternalDomains()
protected function getInternalDomains(): array
{
return [];
}
Expand Down
Loading