Update code standards [PHP 5.6] #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naktibalda
requested changes
Apr 17, 2021
TavoNiievez
force-pushed
the
php56-standards
branch
3 times, most recently
from
d1a6532 to
323f508
Compare
Naktibalda
reviewed
Apr 18, 2021
Naktibalda
reviewed
Apr 18, 2021
TavoNiievez
force-pushed
the
php56-standards
branch
from
323f508 to
b118032
Compare
|
@Naktibalda I removed all the dockblocks that I added in public methods that are as an interface implementation and made the regexp change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type hints and various minor code tweaks.