Skip to content

Refactor InnerBrowser class #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Refactor InnerBrowser class #17

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2020

General refactor to file InnerBrowser.php.

This PR...

  • makes it easier to navigate through the class.
  • reduces the file size from 2065 lines to 1626.
  • does not make logic changes.
  • creates individual traits responsible for the implementation of each interface used in the class.
  • respect the order of implementation of the methods.
  • organizes the methods: private first, protected second and public last.
  • alphabetize methods.
  • uses ʻuse` statements if possible.
  • adds BrowserInterface to see clearly (without docblocks or code implementation) which public methods this class provides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant