Skip to content

Reorganizing some headers #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Reorganizing some headers #378

merged 1 commit into from
Nov 23, 2020

Conversation

ThomasLandauer
Copy link
Member

  • "Get Scenario Metadata" probably isn't perfect, but at least conveys more meaning than "Current Values"
  • This has nothing to do with environments, so I upgraded the header level
  • Shuffle has nothing to do with environments, so I upgraded the header level too
  • Dependencies is only useful when shuffling (right?) so I made it a sub-heading of that
    I didn't change anything inside those chapters.

TODO: I'll add a link from WebDriver module to "Get Scenario Metadata" (as a result of our discussion at Codeception/Codeception#6035), but only after this is merged and online, cause I need the anchor name.

* "Get Scenario Metadata" probably isn't perfect, but at least conveys more meaning than "Current Values"
* This has nothing to do with environments, so I upgraded the header level
* Shuffle has nothing to do with environments, so I upgraded the header level too
* Dependencies is only useful when shuffling (right?) so I made it a sub-heading of that
I didn't change anything *inside* those chapters.

TODO: I'll add a link from WebDriver module to "Get Scenario Metadata" (as a result of our discussion at Codeception/Codeception#6035), but only after this is merged and online, cause I need the anchor name.
@Arhell Arhell requested a review from Naktibalda November 21, 2020 12:33
@Naktibalda Naktibalda merged commit 2dc8fb7 into Codeception:master Nov 23, 2020
@ThomasLandauer ThomasLandauer deleted the patch-6 branch November 23, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants