Add .lowest_common_ancestor #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotdana
force-pushed
the
lowest_common_ancestor_non_chain
branch
from
e2c496d to
c4ad6c1
Compare
Closed
|
@robotdana sqlite3 tests are failing -- can you look into that? |
robotdana
force-pushed
the
lowest_common_ancestor_non_chain
branch
2 times, most recently
from
cde868c to
99e299d
Compare
robotdana
force-pushed
the
lowest_common_ancestor_non_chain
branch
from
99e299d to
0328522
Compare
|
Tests are passing now :) |
|
Nice! Excellent PR (with tests and doc update, even!) 🌟 Idly curious: how expensive is that query on a large tree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #326 that doesn't use .unscoped