Skip to content

[repo] removed unused things #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[repo] removed unused things #2386

wants to merge 6 commits into from

Conversation

chernser
Copy link
Contributor

@chernser chernser commented May 22, 2025

Summary

  • Removes unused dependencies
  • Add direct dependencies
  • Grooms shaded artifacts

Closes #2365
Closes #1745

Checklist

Delete items not relevant to your PR:

  • Closes #
  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Copy link

@chernser chernser marked this pull request as ready for review June 2, 2025 18:17
Copy link

windsurf-bot bot commented Jun 2, 2025

This PR has too many files to review (>50 files).

@mshustov mshustov requested review from mzitnik and Copilot and removed request for mzitnik June 3, 2025 08:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all unused benchmark code in the clickhouse-benchmark module and updates its POM to prune unused dependencies, add direct dependencies, and tidy shade plugin configurations.

  • Deleted obsolete JMH benchmark classes and support files under src/main/java
  • Cleaned up pom.xml by removing unused dependencies and refining the Maven Shade settings

Reviewed Changes

Copilot reviewed 63 out of 63 changed files in this pull request and generated no comments.

File Description
clickhouse-benchmark/pom.xml Pruned unused dependencies, added direct dependencies, and groomed shade plugin configuration
clickhouse-benchmark/src/main/java/** Removed all unused benchmark implementation classes and interfaces

@mshustov mshustov requested a review from mzitnik June 3, 2025 08:49
@mzitnik
Copy link
Contributor

mzitnik commented Jun 3, 2025

@chernser can you please fix the failing tests.

@chernser
Copy link
Contributor Author

chernser commented Jun 3, 2025

@mzitnik yes, I will but as another PR
Let me sync with main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup release artifacts Investigate dependencies
2 participants