-
Notifications
You must be signed in to change notification settings - Fork 585
[repo] removed unused things #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This PR has too many files to review (>50 files). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes all unused benchmark code in the clickhouse-benchmark
module and updates its POM to prune unused dependencies, add direct dependencies, and tidy shade plugin configurations.
- Deleted obsolete JMH benchmark classes and support files under
src/main/java
- Cleaned up
pom.xml
by removing unused dependencies and refining the Maven Shade settings
Reviewed Changes
Copilot reviewed 63 out of 63 changed files in this pull request and generated no comments.
File | Description |
---|---|
clickhouse-benchmark/pom.xml | Pruned unused dependencies, added direct dependencies, and groomed shade plugin configuration |
clickhouse-benchmark/src/main/java/** | Removed all unused benchmark implementation classes and interfaces |
@chernser can you please fix the failing tests. |
@mzitnik yes, I will but as another PR |
Summary
Closes #2365
Closes #1745
Checklist
Delete items not relevant to your PR: